-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift 5.9 toolchain & macOS Sonoma beta #402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking to the time to make these changes and create a pull-request.
It's appreciated!
I've got had few small changes needed when you get a chance.
Some of the changes involve using the Swift 5.9 release toolchain, even though it doesn't exist yet. The reason for that is because I want to avoid using snapshots for a major release of Carton. So I'm going to hold off merging this until 5.9 is released which should happen with Xcode 15's release in early September which isn't very far away.
This change includes updates to package deprecations.
I have made each of the changes you had mentioned, thank you! NOTE: For anyone that may be using this branch in the interim before the Swift 5.9 toolchain is released, this breaks carton on the 5.9 toolchain until it's official release, if you depend on carton working on the pre-release Swift 5.9 Toolchain, please instead use
|
Awesome! Don't forgot to use Swift 5.9 RELEASE in the Dockerfile as well. |
Good catch! I have also bumped the docker base image pending 5.9's release, as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Deferring merge until Swift 5.9 is released. Checks are expected to fail until then.
This release adds SwiftWasm 5.9 toolchain support, which includes usability with macOS Sonoma beta.